Warlock Destro Talent Cross-Link

[mirth_mage]

The Warlock Destro talents Aftermath and Improved Soul Fire are "cross-linked." Meaning if the talent build calls for Aftermath, the Talent Advisor tries to put points in Improved Soul Fire. The same hold true for the reverse (Improved Soul Fire in build causes TA to put points in Aftermath).

Verified with this custom build:

ZygorTalentAdvisor:RegisterBuild("WARLOCK","Custom Destruction DPS (7/3/31)",[[
  3/3 Bane
  3/3 Shadow and Flame  
  2/2 Improved Soul Fire
  2/2 Improved Immolate
  3/3 Backdraft
  1/1 Shadowburn
  1/2 Emberstorm
  2/2 Burning Embers
  2/2 Soul Leech
  2/2 Emberstorm
  3/3 Fire and Brimstone
  2/2 Aftermath
  1/1 Shadowfury
  2/2 Empowered Imp
  1/1 Bane of Havoc
  1/1 Nether Ward
  1/1 Chaos Bolt
  3/3 Dark Arts
  2/2 Doom and Gloom
  3/3 Improved Corruption
  2/2 Jinx
]],[[
  Prime Glyph of Conflagrate
  Prime Glyph of Immolate
  Prime Glyph of Imp
  Major Glyph of Life Tap
  Major Glyph of Soul Link
  Major Glyph of Fear
  Minor Glyph of Drain Soul
  Minor Glyph of Eye of Kilrogg
  Minor Glyph of Unending Breath
]])

[cabby]

Thanks for reporting this. Have you tried it with the newest release that just came out?

This is probably an error in the Registering.lua file as that's where the TA sets up the talents, but I'm not sure how exactly they use the numbers in there as none of the numbers in there match up to anything on WoWHead.

[mirth_mage]

Downloaded and installed the build released today, but it did not fix the error. I swapped the ID's in the Registering.lua file for Improved Soul Fire and Aftermath and the placement of Aftermath and Improved Soul Fire in my custom build. This fixes my custom build, but the Zygor Destruction DPS build fails with the following errors
NOTE: My current character level is 40

ZygorTalentAdvisor: Error! Talent Improved Soul Fire suggested but unavailable!
ZygorTalentAdvisor: Error! Talent Improved Soul Fire suggested but unavailable!
ZygorTalentAdvisor: Error! Talent Backdraft suggested but unavailable!
ZygorTalentAdvisor: Error! Talent Backdraft suggested but unavailable!
ZygorTalentAdvisor: Error! Talent Backdraft suggested but unavailable!
ZygorTalentAdvisor: Error! Talent Burning Embers suggested but unavailable!

And just to be complete here's a summary, with line numbers, of the changes made to Registering.lua:

Comparing files Registering.lua.ORIG and REGISTERING.LUA
***** Registering.lua.ORIG
  548:                  ["Improved Immolate"]=10960,
  549:                  ["Improved Soul Fire"]=11197,
  550:                  ["Emberstorm"]=11181,
***** REGISTERING.LUA
  548:                  ["Improved Immolate"]=10960,
  549:                  ["Improved Soul Fire"]=10940,
  550:                  ["Emberstorm"]=11181,
*****

***** Registering.lua.ORIG
  551:                  ["Improved Searing Pain"]=11196,
  552:                  ["Aftermath"]=10940,
  553:                  ["Backdraft"]=10978,
***** REGISTERING.LUA
  551:                  ["Improved Searing Pain"]=11196,
  552:                  ["Aftermath"]=11197,
  553:                  ["Backdraft"]=10978,
*****

And to be really complete my updated custom build looks like this:

ZygorTalentAdvisor:RegisterBuild("WARLOCK","Custom Destruction DPS (7/3/31)",[[
  3/3 Bane
  3/3 Shadow and Flame  
  2/2 Aftermath
  2/2 Improved Immolate
  3/3 Backdraft
  1/1 Shadowburn
  1/2 Emberstorm
  2/2 Burning Embers
  2/2 Soul Leech
  2/2 Emberstorm
  3/3 Fire and Brimstone
  2/2 Improved Soul Fire
  1/1 Shadowfury
  2/2 Empowered Imp
  1/1 Bane of Havoc
  1/1 Nether Ward
  1/1 Chaos Bolt
  3/3 Dark Arts
  2/2 Doom and Gloom
  3/3 Improved Corruption
  2/2 Jinx
]],[[
  Prime Glyph of Conflagrate
  Prime Glyph of Immolate
  Prime Glyph of Imp
  Major Glyph of Life Tap
  Major Glyph of Soul Link
  Major Glyph of Fear
  Minor Glyph of Drain Soul
  Minor Glyph of Eye of Kilrogg
  Minor Glyph of Unending Breath
]])

[ZG Support 1]

We have looked into the newest version of our Talent Advisor and we are showing a different build in the live version than you are showing here. Make sure to delete your current guides from your Addons and try re-downloading them fresh. Let us know if you are still having this problem after trying this.

[cabby]

Support, you mis-read his posts. The build he's showing is a custom build that he's had to use to get it to work because the Zygor build isn't working as intended.

[mirth_mage]

Cabby's close to right. I wrote a custom build because:
A) I wanted a build with Shadowburn. IMO it's a nice finisher with the added bonus of gaining Soul Shards
B) I misread "Incinerate" as "Immolate" for a couple of talents, and thought I had a better order for learning the talents. In my defense I was really tired at the time.

On the surface the Zygor build appears to work so I understand how the devs would have overlooked it in the recent set of fixes. Let's look at the actual Zygor Warlock Destruction DPS build:

ZygorTalentAdvisor:RegisterBuild("WARLOCK","Zygor Destruction DPS (3/7/31)",[[
    3/3 Bane
    2/2 Improved Immolate
    2/2 Improved Soul Fire
    3/3 Shadow and Flame    
    3/3 Backdraft
    2/2 Aftermath
    2/2 Burning Embers
    3/3 Backlash
    3/3 Fire and Brimstone
    1/1 Shadowfury
    1/2 Emberstorm
    2/2 Empowered Imp
    1/1 Bane of Havoc
    1 Emberstorm // (Now 2/2)
    1/2 Soul Leech
    1/1 Chaos Bolt
    3/3 Dark Arts
    2/3 Demonic Embrace
    2/2 Demonic Rebirth
    3/3 Improved Corruption
]],[[
    Prime Glyph of Conflagrate
    Prime Glyph of Immolate
    Prime Glyph of Imp
    Major Glyph of Life Tap
    Major Glyph of Soul Link
    Major Glyph of Soulstone
    Minor Glyph of Drain Soul
    Minor Glyph of Eye of Kilrogg
    Minor Glyph of Unending Breath
]])

As you can see, just below Improved Immolate is Improved Soul Fire. This is a 3rd tier talent and cannot be learned where this build has it specified. Instead the in-game TA has you put points in Aftermath after Improved Immolate, then put points in Improved Soul Fire after Backdraft (where Aftermath is listed above). So it seems someone on your dev team knows about this problem and has put in a work-around.

[ZG Support 1]

Ok, thank you for the information, we will look into making sure that these Talents are listed in the correct order and try to get them released in an update soon.

[Cartman]

Ok, thank you for the information, we will look into making sure that these Talents are listed in the correct order and try to get them released in an update soon.

Please also note the first post of this thread about the bug with the two talents then.