Log in to ZYGOR
Log in with social media
OR
Log in with Zygor account

Announcement

Collapse
No announcement yet.

Doing Engineering and smelting some bars

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

    Doing Engineering and smelting some bars

    I get this error here.


    Message: Interface\AddOns\ZygorGuidesViewer\Goal.lua:2087: Usage: GetRecipeItemLink(recipeID)
    Time: 07/23/16 04:23:51
    Count: 169
    Stack: [C]: in function `GetRecipeItemLink'
    Interface\AddOns\ZygorGuidesViewer\Goal.lua:2087: in function `get_recipe'
    Interface\AddOns\ZygorGuidesViewer\Goal.lua:2554: in function `GetText'
    ...rface\AddOns\ZygorGuidesViewer\ZygorGuidesViewe r.lua:2317: in function `UpdateFrame'
    ...rface\AddOns\ZygorGuidesViewer\ZygorGuidesViewe r.lua:3587: in function `func'
    ...rface\AddOns\ZygorGuidesViewer\ZygorGuidesViewe r.lua:884: in function `?'
    ...ore\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:145: in function <...ore\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:145>
    [string "safecall Dispatcher[2]"]:4: in function <[string "safecall Dispatcher[2]"]:4>
    [C]: ?
    [string "safecall Dispatcher[2]"]:13: in function `?'
    ...ore\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:90: in function `Fire'
    ...ZygorGuidesViewer\Libs\AceEvent-3.0\AceEvent-3.0.lua:120: in function <...ZygorGuidesViewer\Libs\AceEvent-3.0\AceEvent-3.0.lua:119>

    Locals: <none>

    #2
    I'm receiving the same error while trying to level up tailoring on a twink of mine. Seems to appear whenever the guide wants me to craft an item.

    I've just performed a clean installation (according to your latest blog post) and disabled all other addons. This did not resolve the issue. I'm playing on horde.

    Code:
    Message: Interface\AddOns\ZygorGuidesViewer\Goal.lua:2087: Usage: GetRecipeItemLink(recipeID)
    Time: 07/23/16 11:25:27
    Count: 11
    Stack: [C]: in function `GetRecipeItemLink'
    Interface\AddOns\ZygorGuidesViewer\Goal.lua:2087: in function `get_recipe'
    Interface\AddOns\ZygorGuidesViewer\Goal.lua:2494: in function `GetText'
    ...rface\AddOns\ZygorGuidesViewer\ZygorGuidesViewer.lua:2317: in function `UpdateFrame'
    ...rface\AddOns\ZygorGuidesViewer\ZygorGuidesViewer.lua:1753: in function `?'
    ...ZygorGuidesViewer\Libs\AceTimer-3.0\AceTimer-3.0.lua:41: in function <...ZygorGuidesViewer\Libs\AceTimer-3.0\AceTimer-3.0.lua:36>
    
    Locals: (*temporary) = nil
    Edit:

    I've taken a look at the code myself and built a temporarily fix which at least shows what to craft how often.

    Goal.lua, Function at line 2083:
    Code:
    function get_recipe(skill,spellid)
    	if not C_TradeSkillUI.GetRecipeInfo(spellid) then return nil,"closed" end
    
    	local recipeInfo = C_TradeSkillUI.GetRecipeInfo(spellid)
    	local difficulty = recipeInfo["difficulty"]
    	local learned = recipeInfo["learned"]
    	local numAvailable = recipeInfo["numAvailable"]
    	local numSkillUps = recipeInfo["numSkillUps"]
    	local recipeID = recipeInfo["recipeID"]
    	
    	local productlink = C_TradeSkillUI.GetRecipeItemLink(recipeID)
    	local _,productid = productlink:match("|H(%w+):(%d+)")
    	local productid = tonumber(productid)
    	if not learned then return nil,"not learned" end
    
    	return {avail=numAvailable,type=type,numup=numSkillUps and numSkillUps>0 and numSkillUps or 1, lastskill=skill, itemid=productid}
    end
    I've noticed two issues in the code:
    • You are declaring "recipeID" but are using it as "recipeid" afterwards
    • The order of the return values of GetRecipeInfo seems to have changed


    Edit 2

    I've noticed another error. You seem to miss some error types in your Goal.CraftingErrorMsgs table.

    Replacing the following line in Goal.lua (2531 after applying my previous fix):

    Code:
    if errortype then extramsg = Goal.CraftingErrorMsgs[errortype]:format(skill_loc) end
    with this

    Code:
    if errortype then extramsg = "Fixme" end -- Goal.CraftingErrorMsgs[errortype]:format(skill_loc) end
    works as a temporarily solution.
    Last edited by LordofWar; July 23, 2016, 06:08 AM.

    Comment


      #3
      Have you tested with all other addons disabled?
      Become a Fan of Zygor Guides on Facebook:
      http://www.facebook.com/pages/Zygor-...04933799556988

      Follow Zygor Guides on Twitter:
      http://twitter.com/zygorguides

      Comment


        #4
        Thank you for your reply. I've had them disabled, as stated above in my first post.

        Originally posted by LordofWar View Post
        I've just performed a clean installation (according to your latest blog post) and disabled all other addons. This did not resolve the issue. I'm playing on horde.

        Comment


          #5
          Just had to be sure.

          We will look into this.
          Become a Fan of Zygor Guides on Facebook:
          http://www.facebook.com/pages/Zygor-...04933799556988

          Follow Zygor Guides on Twitter:
          http://twitter.com/zygorguides

          Comment


            #6
            same as other guy. i have disabled all of them. glad we can get this to your attention. if you get this error it will bug out zygor and you are forced to disable it.

            Comment

            Working...
            X