Log in to ZYGOR
Log in with social media
OR
Log in with Zygor account

Announcement

Collapse
No announcement yet.

ElvUI - Zygor showing above open bags

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

    ElvUI - Zygor showing above open bags

    Hi,

    Since last ElvUI update (10.79) the Zygor Guide Viewer appears above open bags, see screenshot:

    Zygor-Elvui-bags.png

    Don't know on which side I had to post, so had a try here

    #2
    We follow standard strata stuff for the windows so it looks like ElvUI lowered the strata for their bag window. Should probably get them raise the strata for the bag window or add an option to the bag window for it to always be on top.
    Become a Fan of Zygor Guides on Facebook:
    http://www.facebook.com/pages/Zygor-...04933799556988

    Follow Zygor Guides on Twitter:
    http://twitter.com/zygorguides

    Comment


      #3
      According to their changelog they fixed it to avoid an issue with the world map (so lowered it):

      Fixed bags from being shown over the WorldMapFrame (#592).
      Is there a way to change Viewer's "layer"? (I guess it's what you call "strata")
      If not, I guess I'll raise the issue on their side.

      Comment


        #4
        The dev team probably will not change the layer because all other bag addons don't have an issue with this and will show above the guide viewer.
        Become a Fan of Zygor Guides on Facebook:
        http://www.facebook.com/pages/Zygor-...04933799556988

        Follow Zygor Guides on Twitter:
        http://twitter.com/zygorguides

        Comment


          #5
          I'm having the same problem. But I don't think the problem is ElvUI.

          According to: https://git.tukui.org/elvui/elvui/issues/592
          Looks like they didn't adjust the bag frame strata, they adjusted the WorldMapFrame strata to "High".

          Code:
          WorldMapFrame.ScrollContainer:CreateBackdrop()
          	WorldMapFrame:CreateBackdrop("Transparent")
          
          	WorldMapFrame:SetFrameStrata("HIGH")
          
          	WorldMapFrameHomeButton:StripTextures()
          	WorldMapFrameHomeButton:CreateBackdrop("Default", true)
          	WorldMapFrameHomeButton.backdrop:SetPoint("TOPLEFT", WorldMapFrameHomeButton, "TOPLEFT", 0, 0)
          https://git.tukui.org/elvui/elvui/co...f0181ca5b61db8

          What I did find was that when the UI first loads, the viewer nicely sits behind the bags. However, when I click and drag the viewer, the viewer moves up above the bags. Then when I stop dragging and release the viewer, the viewer stays above the bags. When I reload the UI, Zygor Viewer goes back behind the bags again. Rinse and repeat.

          I currently haven't found anything else that triggers this to occur, however, sometimes around 30min to a hour of leveling I notice the viewer is back above the bags again without having to drag the viewer.
          Last edited by cnewman777; August 25, 2018, 01:16 AM.

          Comment


            #6
            Tested with default UI. Result: Zygor Viewer starts behind the default bag frame. When I drag the Zygor Viewer, the addon moves above the bag frame. When I close and re-open the bag frame, the bag frame shows once again over the Zygor Viewer addon. Good.

            Tested with Bagnon. Result: Zygor Viewer starts behind Bagnon frame. When I drag the Zygor Viewer, the addon stays behind the Bagnon frame. Acceptable.

            Tested with AdiBags. Result: Zygor Viewer starts behind Adibags frame. When I drag the Zygor Viewer, the addon stays behind the Adibags frame. Acceptable.

            Tested with ElvUI. Result: Zygor Viewer starts behind the ElvUI Bag frame. When I drag the Zygor Viewer, the addon moves above the ElvUI frame. I close the ElvUI bag frame and re-open. The ElvUI bag frame opens behind the Zygor Viewer. Not Acceptable.

            While the results of the other bag addons are acceptable, the behavior is not the same as of the default UI. And it also appears we are at a stalemate between addon developers. So ElvUI users options are:
            1. Use the default Blizzard UI for managing the bags. (its an option within ElvUI)
            2. Use another bag addon along with ElvUI
            3. Don't use ElvUI
            4. Don't use Zygor Guides. (Don't recommend)

            Comment


              #7
              No response from Zygor has left me to find my own solution to this problem. Looking at the frameStrata of the Zygor Viewer I found that the ZygorGuidesViewerFrameMaster is set to 'MEDIUM' which is in conflict with the Bag frame from ElvUI. See image...



              Fix:
              /script ZygorGuidesViewerFrameMaster:SetFrameStrata('LOW')

              Run the above script when the problem occurs and it "should" put the Zygor Viewer back behind the Bag frame on the ElvUI.
              Last edited by cnewman777; August 31, 2018, 11:22 PM.

              Comment


                #8
                From your description of what happens it would seem like ElvUI does a proper setting of it's strata during the OnLoad section (entering game, reload UI, zone load) but they do not make sure the strata is still set properly during any updates such as when bag windows are displayed or hidden. As you have pointed out the guide viewer works properly with all other bag addons (and will probably act the same with other addon windows in general) so there is nothing for us to fix.
                Become a Fan of Zygor Guides on Facebook:
                http://www.facebook.com/pages/Zygor-...04933799556988

                Follow Zygor Guides on Twitter:
                http://twitter.com/zygorguides

                Comment


                  #9
                  First never said the addon worked properly with other addons. The behavior was acceptable with the other addons however, compared against the default UI.. the behavior is not the same experience.

                  Why does 'ZygorGuidesViewerFrameMaster' need to be set to 'MEDIUM'? Your viewer seems to be working just fine when the 'ZygorGuidesViewerFrameMaster' is set to 'LOW'.
                  Last edited by cnewman777; September 1, 2018, 12:41 AM.

                  Comment


                    #10
                    So I should go over to the ElvUI git issue page and create an issue saying that the Zygor Leveling Addon Author is claiming your bag frame is not maintaining its 'OnLoad' frameStrata of 'MEDIUM' throughout the game when other updates occur such as show or hide?

                    https://git.tukui.org/groups/elvui/-/issues

                    Comment


                      #11
                      The guide viewer works as intended allowing other UI elements to show on top of the guide viewer when they have focus. There is nothing to fix in the guide viewer. No need to submit an issue with ElvUI as I'm sure they probably also see it as a non-issue.
                      Become a Fan of Zygor Guides on Facebook:
                      http://www.facebook.com/pages/Zygor-...04933799556988

                      Follow Zygor Guides on Twitter:
                      http://twitter.com/zygorguides

                      Comment


                        #12
                        I don't mean to be an ass here, and I apologize if you felt I've been that way(especially over the years...lol), but there is a problem. The Zygor Viewer, after dragging or some UI update, is persistently showing ABOVE the ElvUI Bag Frame. That is the initial problem. The next problem is that both sides don't want to accommodate the other. Why should you? You shouldn't be responsible for the behavior of another addon and ElvUI shouldn't be responsible for the behavior of your addons. I get it. But you both operate in the same space. In the same UI. You both have to figure out how to play nicely with each other.

                        And because of this stalemate, and in your case because you have paying customers, the customer loses here. You really have a great addon. That is why I have given you soooo much of my money of the years.

                        I personally think it would be a simple fix to just change the ZygorGuidesViewerFrameMaster FrameStrata to 'LOW'.

                        Comment

                        Working...
                        X