Click item step bugged

[Cartman]

Just saw this at step 247 in the Alliance Vashj'ir guide:
.click Alliance Survival Kit##7539

This leads to a click to continue message, possibly a parsing error with the new |click command.

Edit: step 249 has the same problem (you should click ropes on the ground).
I expect every .click step to show this behavior.

[Cartman]

I found another problem related to this.
Alliance Hyjal step 235 was grey and therefore skipped. It looks like this:
step
goto 71.9,75.2
.clicknpc Emerald Drake##40780 |invehicle |noway |c |q 25608

If I remove the clicknpc thing and leave only the |invehicle part the step works correctly.

[Cartman]

***bump***

[zgdev2]

***bump***

I stand ready. Sorry, thought it was a guide text wording problem. So, it just parses incorrectly, right?

[Cartman]

No problem, you have been busy with other things
The problem is that all .click steps seem to show the "click to continue" text instead of "click item".
For example Alliance Vashj'ir leveling guide step 1:
.click Hero's Call Board##10016
This can be seen in every of those steps even when completed.

The other problem with the .clicknpc is not visible when the step is green. I think in that case the step was not parsed beyond the name and ID, it was simply grey and skipped though I had the quest and was not riding the drake.
After removing the .clicknpc part the step worked correctly, was not grey and the guide stepped ahead when mounting the drake.
Maybe there's a daily guide with such a step to test it.

Edit: did not find a daily quest in the guides but there's one not included in the guide:
http://www.wowhead.com/quest=29177
Should be easy to make a test guide for that.

[Cartman]

Here's some copy paste guide for the quest I linked before:

ZygorGuidesViewer:RegisterGuide("Contributed\\Dailies\\Mount Hyjal",[[
	description Test for one quest
	author Cartman
	startlevel 85
	step 1
		goto Mount Hyjal,39.1,58.3 |n
		.' Go inside the blue portal |goto 38.77,58.01 <0.3 |noway |c
	step
		goto 37.2,56.2
		.talk 40578
		..accept 29177
	step
		goto 37.2,56.1
		.click the Twilight Weapon Rack##130
		.collect Twilight Firelance##52716 |q 29177
	step
		 goto 37.4,56.0
		 .' Equip the Twilight Firelance |use Twilight Firelance##52716
		//does not work:
		//.clicknpc Aviana's Guardian##40723 |invehicle |noway |c |q 29177
		//does not work:
		//.clicknpc Aviana's Guardian##40723
		//works:
		.' Ride Aviana's Guardian |invehicle |noway |c |q 29177
	step
		goto 35.4,51.7
		.' Use your Flap ability on your hotbar repeatedly to fly around this area
		.' Fly into Twilight Firebirds to joust them |tip Be careful, don't let the burning Falling Boulders hit you.
		.kill 10 Twilight Lancer##40660 |q 29177/1
		'|modelnpc 40650
	step
		goto 37.2,56.2
		.' Use your Flap ability on your hotbar repeatedly to fly to this spot
		.talk 40578
		..turnin 29177
	step
		'Click the red arrow on your hot bar to get off the hippogryph |outvehicle |c
	step
		goto 39.1,58.1 |n
		.' Don't forget to equip your real weapon again
		.' Go inside the blue glowing orb |goto 39.1,58.1,0.5 |noway |c
]])

[zgdev2]

Cannot reproduce those. Are you positive it happens with latest updates?

[zgdev2]

Proofpic:

[Cartman]

I'll switch to English client as I use German and report back in a few minutes.

[zgdev2]

I'll switch to English client as I use German and report back in a few minutes.

Don't bother I can read German :P

[Cartman]

Ok, checked it with German WoW and it looks like this:


English was working fine.

One other thing I noticed, the modelviewer does not come back when switching the UI off and on with ALT+y.

[zgdev2]

Ok, checked it with German WoW and it looks like this: English was working fine.

So we are speaking about a bug specific to German version? Let me install one to test.

One other thing I noticed, the modelviewer does not come back when switching the UI off and on with ALT+y.

Noice, thank you. Will fix this too in the meanwhile, I think I know where it comes from.

[Cartman]

So we are speaking about a bug specific to German version?

Maybe not only German but at least not English

But the clicknpc thing does not work with English WoW also.
This code does not work:
.clicknpc Aviana's Guardian##40723 |invehicle |noway |c |q 29177
This works:
.' Ride Aviana's Guardian |invehicle |noway |c |q 29177

This is a bug report of the one that doesn't work:

3. . <Click Aviana's Guardian>
force_noway: true
action: clicknpc
npc: Aviana's Guardian
dirtytext: true
npcid: 40723
prepared: true
force_complete: true
quest: "Vigilance on Wings" ##29177 (no goal) - quest in log (id: not completed)
Status: impossible (completable: complete? no, possible? no, progress nil, auxiliary? no)

[Cartman]

I found the problem for the .click steps.
From the deDE.lua localization file:
["stepgoal_click"] = "Bitte hier anklicken.",
(this should be the string for stepgoal_confirm).

And this is in the enUS file:
["stepgoal_click"] = "Click %s",
["stepgoal_clicknpc"] = "Click %s",
["stepgoal_click_done"] = "Click %s",
["stepgoal_clicknpc_done"] = "Click %s",

Don't know if missing localizations are a problem but the stepgoal_click is definitely wrong
I looked into es, fr and kr files and that string is in none of them so if they then use English it should be ok.

Then there's still the clicknpc problem that is language independent.

[daeymien]

["stepgoal_click"] = "Bitte hier anklicken.",

[humour]
At least the German translations are nicer about asking you to click things rather than just "Hier ankilcken".
[/humour]