Zygor 6.1 breaks other addons configuration screens

[Zygor Dev 1]

Hmm, well, there aren't any NEW Ace libs - we're based on rev. 1050, and that's the newest.

The spammy message was removed now, it was a leftover debugging bit which shouldn't've gone into a release.
As for the SetWidth error, we're working on it now.

[Zygor Dev 1]

There we go, problem solved in 6.1.15131. Thanks for the detailed reports!

[7ba2fa02]

You cannot ship a changed version of a shared library. You have changed the behaviour of many other addons. If a new official release comes out that addresses an issue, it will be ignored because yours has a much higher release number.

If you need to change the behaviour of an Ace3 widget, you make a NEW widget and ship that.

If you feel that you desperately need to change the library code, at least rename it so it doesn't cause collisions with other addons. If the library was "ZygorAceConfigDialog-3.0", then there would be no collision.

[reddevilskull]

After updating Zygor to 6.1.15131, STILL having conflict between Zygor and other Addons like ElvUI, Skada, Masque.

Below the messages I receive upon entering to the Profile section for at least the Addons mention above. Having me to disable Zygor in order to do changes or change profiles (very annoying)

9x ...er\Libs\AceGUI-3.0-1034\widgets\AceGUIWidget-CheckBox.lua:231: attempt to call method 'SetDescriptionFont' (a nil value)
...er\Libs\AceGUI-3.0-1034\widgets\AceGUIWidget-CheckBox.lua:231: in function `SetDescription'
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-1061.lua:1151: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:1055>
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-1061.lua:1588: in function `FeedGroup'
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-1061.lua:1513: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:1493>
(tail call): ?
[C]: ?
[string "safecall Dispatcher[3]"]:9: in function <[string "safecall Dispatcher[3]"]:5>
(tail call): ?
...Ons\ZygorGuidesViewer\Libs\AceGUI-3.0\AceGUI-3.0-1034.lua:314: in function `Fire'
...ibs\AceGUI-3.0-1034\widgets\AceGUIContainer-TreeGroup.lua:509: in function `SetSelected'
...ibs\AceGUI-3.0-1034\widgets\AceGUIContainer-TreeGroup.lua:194: in function <...ibs\AceGUI-3.0\widgets\AceGUIContainer-TreeGroup.lua:190>

Locals:
nil

PS. Did a clean install also giving the same results.

[Zygor Dev 1]

You cannot ship a changed version of a shared library.

Sadly, to change some core libs we'd need to change almost all of the files they rely on, and Ace libs are very rarely updated, and all our changes were supposed to be fully compatible with all other addons using the libs, of course - apparently we missed something. We'll fix the problems found, of course, but we'll want to avoid cloning the whole set of libs if that can be avoided.

[myrroddin]

Is it not possible to write a chunk of code or library that plugs into Ace3, loaded via LibStub? I know things like AceGUI-SharedMediaWidgets and LibDualSpec, and my unreleased LibAboutOptions-2 all do it without changing the base code of Ace3.

[7ba2fa02]

Sadly, to change some core libs we'd need to change almost all of the files they rely on, and Ace libs are very rarely updated, and all our changes were supposed to be fully compatible with all other addons using the libs, of course - apparently we missed something. We'll fix the problems found, of course, but we'll want to avoid cloning the whole set of libs if that can be avoided.

If the changes you're making really are improvements that don't break existing functionality, then why don't you contribute the patches to the official Ace project? Then the changes could be vetted by people who know the libraries and could catch likely conflicts.

If you continue to ship altered shared libraries, then you are constantly running the risk of breaking other addons since you cannot possibly test them with every addon that uses them.

[schroeg]

I also still get a lua error if I try to select a Addon settings like:

ElvUI->Profiles:
4x ...er\Libs\AceGUI-3.0-1034\widgets\AceGUIWidget-CheckBox.lua:231: attempt to call method 'SetDescriptionFont' (a nil value)
...er\Libs\AceGUI-3.0-1034\widgets\AceGUIWidget-CheckBox.lua:231: in function `SetDescription'
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-1061.lua:1199: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:1072>
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-1061.lua:1704: in function `FeedGroup'
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-1061.lua:1989: in function `Open'
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-1061.lua:1896: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:1894>
(tail call): ?
[C]: ?
[string "safecall Dispatcher[2]"]:9: in function <[string "safecall Dispatcher[2]"]:5>
(tail call): ?
...Ons\ZygorGuidesViewer\Libs\AceGUI-3.0\AceGUI-3.0-1034.lua:314: in function `Fire'
...GUI-3.0\widgets\AceGUIContainer-BlizOptionsGroup.lua:20: in function <...GUI-3.0\widgets\AceGUIContainer-BlizOptionsGroup.lua:19>
[C]: in function `Show'
FrameXML\InterfaceOptionsFrame.lua:28: in function <FrameXML\InterfaceOptionsFrame.lua:17>
[C]: in function `InterfaceOptionsList_DisplayPanel'
FrameXML\InterfaceOptionsFrame.lua:46: in function `InterfaceOptionsListButton_OnClick'
[string "*:OnClick"]:2: in function <[string "*:OnClick"]:1>

Locals:
nil


SilverDragon->Icon
3x ...er\Libs\AceGUI-3.0-1034\widgets\AceGUIWidget-CheckBox.lua:231: attempt to call method 'SetDescriptionFont' (a nil value)
...er\Libs\AceGUI-3.0-1034\widgets\AceGUIWidget-CheckBox.lua:231: in function `SetDescription'
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-1061.lua:1199: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:1072>
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-1061.lua:1704: in function `FeedGroup'
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-1061.lua:1628: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:1608>
(tail call): ?
[C]: ?
[string "safecall Dispatcher[3]"]:9: in function <[string "safecall Dispatcher[3]"]:5>
(tail call): ?
...Ons\ZygorGuidesViewer\Libs\AceGUI-3.0\AceGUI-3.0-1034.lua:314: in function `Fire'
...ibs\AceGUI-3.0-1034\widgets\AceGUIContainer-TreeGroup.lua:509: in function `SetSelected'
...ibs\AceGUI-3.0-1034\widgets\AceGUIContainer-TreeGroup.lua:194: in function <...ibs\AceGUI-3.0\widgets\AceGUIContainer-TreeGroup.lua:190>

Locals:
nil

AdiButtonAuras->Profiles
1x ...er\Libs\AceGUI-3.0-1034\widgets\AceGUIWidget-CheckBox.lua:231: attempt to call method 'SetDescriptionFont' (a nil value)
...er\Libs\AceGUI-3.0-1034\widgets\AceGUIWidget-CheckBox.lua:231: in function `SetDescription'
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-1061.lua:1199: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:1072>
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-1061.lua:1704: in function `FeedGroup'
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-1061.lua:1989: in function `Open'
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-1061.lua:2017: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:2015>
(tail call): ?
[C]: ?
[string "safecall Dispatcher[2]"]:9: in function <[string "safecall Dispatcher[2]"]:5>
(tail call): ?
...Ons\ZygorGuidesViewer\Libs\AceGUI-3.0\AceGUI-3.0-1034.lua:314: in function `Fire'
...GUI-3.0\widgets\AceGUIContainer-BlizOptionsGroup.lua:20: in function <...GUI-3.0\widgets\AceGUIContainer-BlizOptionsGroup.lua:19>
[C]: in function `Show'
FrameXML\InterfaceOptionsFrame.lua:28: in function <FrameXML\InterfaceOptionsFrame.lua:17>
[C]: in function `InterfaceOptionsList_DisplayPanel'
FrameXML\InterfaceOptionsFrame.lua:46: in function `InterfaceOptionsListButton_OnClick'
[string "*:OnClick"]:2: in function <[string "*:OnClick"]:1>

Locals:
nil

Skada->Profiles
1x ...er\Libs\AceGUI-3.0-1034\widgets\AceGUIWidget-CheckBox.lua:231: attempt to call method 'SetDescriptionFont' (a nil value)
...er\Libs\AceGUI-3.0-1034\widgets\AceGUIWidget-CheckBox.lua:231: in function `SetDescription'
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-1061.lua:1199: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:1072>
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-1061.lua:1704: in function `FeedGroup'
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-1061.lua:1989: in function `Open'
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-1061.lua:1896: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:1894>
(tail call): ?
[C]: ?
[string "safecall Dispatcher[2]"]:9: in function <[string "safecall Dispatcher[2]"]:5>
(tail call): ?
...Ons\ZygorGuidesViewer\Libs\AceGUI-3.0\AceGUI-3.0-1034.lua:314: in function `Fire'
...GUI-3.0\widgets\AceGUIContainer-BlizOptionsGroup.lua:20: in function <...GUI-3.0\widgets\AceGUIContainer-BlizOptionsGroup.lua:19>
[C]: in function `Show'
FrameXML\InterfaceOptionsFrame.lua:28: in function <FrameXML\InterfaceOptionsFrame.lua:17>
[C]: in function `InterfaceOptionsList_DisplayPanel'
FrameXML\InterfaceOptionsFrame.lua:46: in function `InterfaceOptionsListButton_OnClick'
[string "*:OnClick"]:2: in function <[string "*:OnClick"]:1>

Locals:
nil


These are just a small list of addons and it seems only this error for now. Please check if no other changes are broken in the Ace3 libraries.
1x ...er\Libs\AceGUI-3.0-1034\widgets\AceGUIWidget-CheckBox.lua:231: attempt to call method 'SetDescriptionFont' (a nil value)

Just checked against the Ace3-r1151 and see that this has been changed by Zygor.
I changed it to the following and the errors seems to be gone:
if self.descFont and self.descFontSize then
self:SetDescriptionFont(self.descFont,self.descFon tSize)
end

[Zygor Dev 1]

If the changes you're making really are improvements that don't break existing functionality, then why don't you contribute the patches to the official Ace project? Then the changes could be vetted by people who know the libraries and could catch likely conflicts.

We tried that. Ace people weren't really interested, and suggested we keep rolling our own. Our modifications largely concentrated on adding to the AceGUI controls the option to change their fonts - and that's something that apparently wasn't wanted in the trunk of the libs.

If you continue to ship altered shared libraries, then you are constantly running the risk of breaking other addons since you cannot possibly test them with every addon that uses them.

We could make sure our modifications only ever ADD functionality that no other addon would normally access - but in the long run indeed it could've made it a problem every time an Ace lib gets updated. At that time we chose to just make sure we'll always update quickly enough - but apparently it's not going to cut it.

The relevant libs were hereby isolated and made local. Please report if any more problems arise!

[myrroddin]

EDIT: I know people are on holidays, and don't expect an answer until after the New Year. I am merely adding to the thread.

I am using the beta version of the guides, and am still getting the config error conflict. At this time, I am rewriting SmartRes2, hence the reference in the error code. I have not tried to trigger the error with other addons.

If you need to test the conflict with SmartRes2, please let me know, as the version listed on Wowace won't work in Legion, and the repository is outdated, albeit updated regularly as I write code. I can zip up my latest build for you, if necessary.

1x ...TA\Libs\AceGUI-3.0-1034\widgets\AceGUIWidget-CheckBox.lua:231: attempt to call method 'SetDescriptionFont' (a nil value)
...TA\Libs\AceGUI-3.0-1034\widgets\AceGUIWidget-CheckBox.lua:231: in function `SetDescription'
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-1061.lua:1199: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:1072>
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-1061.lua:1704: in function `FeedGroup'
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-1061.lua:1628: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:1608>
(tail call): ?
[C]: ?
[string "safecall Dispatcher[3]"]:9: in function <[string "safecall Dispatcher[3]"]:5>
(tail call): ?
...ygorGuidesViewer-BETA\Libs\AceGUI-3.0\AceGUI-3.0-1034.lua:314: in function `Fire'
...Ace3\AceGUI-3.0-1034\widgets\AceGUIContainer-TabGroup.lua:156: in function `SelectTab'
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-1061.lua:1740: in function `FeedGroup'
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-1061.lua:1989: in function `Open'
SmartRes2\SmartRes2-@project-version@.lua:178: in function `?'
Ace3\AceConsole-3.0\AceConsole-3.0-7.lua:94: in function `?'
FrameXML\ChatFrame.lua:4385: in function `ChatEdit_ParseText'
FrameXML\ChatFrame.lua:4053: in function `ChatEdit_SendText'
FrameXML\ChatFrame.lua:4089: in function `ChatEdit_OnEnterPressed'
[string "*:OnEnterPressed"]:1: in function <[string "*:OnEnterPressed"]:1>

Locals:
nil

[ZG Support 1]

Try it with the release version of the guides. I know we fixed the Ace conflict stuff already so it's possible those fixes were not applied to the beta version of the guides.