Zygor Viewer spamming general chat window

[prowell]

The Zygor Guide viewer appears to generate a LOT of spam on one of my toons.

Zygor Guide Viewer: Finding proper starting section
Zygor Guide Viewer: Cannot find a proper starter section for you! What are you..??

Switching between map co-ordinate areas appears to trigger this message series. I have seen as many as 10 in a row when near the edges of two zones. I always also see it when logging into the game (once, with possibly a disabling addon message would make sense) and then tons of times as farming on this toon.


Besides running a different addon list for this character (ie, turn Zygor guides off since he doesn't need it), what can I do so I don't see all this spam?

[prowell]

Oh, the other trigger for the spam is leaving combat...

[cabby]

What level is your character and do you own any of the MoP guides?

[prowell]

88 now. This did NOT start with MOP though, just I'm playing the character more so it became more annoying.
It does seem to affect toons that have finished all quests for leveling and do not currently have a guide selected. It appears the work-around may be as simple as select a guide manually (mount farming for instance). I selected a guide, and have not seen the message for 15 mins of playing. That's unlike before where I got it EVERY fight, EVERY ore mined, etc.

[cabby]

We just put out an update that might have solved this. Can you please update and let us know if you still see those messages on a max level character with no guide selected. Don't forget to exit WoW before updating the guides.

[prowell]

uhg, the default stealth skin is UGLY.
And not fixed. I got 5 spams within 5 minutes of starting.

[prowell]

Date: 2012-10-07 01:22:52
ID: 1
Error occured in: AddOn: ZygorGuidesViewer
Count: 6
Message: Note: AddOn ZygorGuidesViewer attempted to call a protected function (ZygorGuidesViewerFrame:SetHeight()) during combat lockdown.
Debug:
[C]: SetHeight()
...rface\AddOns\ZygorGuidesViewer\ZygorGuidesViewe r.lua:2604: ?()
...rface\AddOns\ZygorGuidesViewer\ZygorGuidesViewe r.lua:2187: UpdateFrame()
...rface\AddOns\ZygorGuidesViewer\ZygorGuidesViewe r.lua:2798: func()
...rface\AddOns\ZygorGuidesViewer\ZygorGuidesViewe r.lua:356: ?()
...ist\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:147:
...ist\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
[string "safecall Dispatcher[1]"]:4:
[string "safecall Dispatcher[1]"]:4
[C]: ?
[string "safecall Dispatcher[1]"]:13: ?()
...ist\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:92: Fire()
...s\AckisRecipeList\libs\AceEvent-3.0\AceEvent-3.0.lua:120:
...s\AckisRecipeList\libs\AceEvent-3.0\AceEvent-3.0.lua:119
Locals:
None
AddOns:
Swatter, v5.1.DEV.338
AckisRecipeList, v2.4.1
Altoholic, v5.0.001d
Auctionator, v3.0.5
AutoBar, vv5.0.4.07
Babylonian, v5.1.DEV.332
BrokerQC, v.70
Configator, v5.1.DEV.335
DataStore, v5.0.001
DataStoreAchievements, v5.0.001
DataStoreAgenda, v5.0.001
DataStoreAuctions, v5.0.001
DataStoreCharacters, v5.0.001
DataStoreContainers, v5.0.001
DataStoreCrafts, v5.0.001
DataStoreCurrencies, v5.0.001
DataStoreInventory, v5.0.001
DataStoreMails, v5.0.001
DataStorePets, v5.0.001
DataStoreQuests, v5.0.001
DataStoreReputations, v5.0.001
DataStoreSpells, v5.0.001
DataStoreStats, v5.0.001
DataStoreTalents, v5.0.001
DBMCore, v
DBMLDB, v
DebugLib, v5.1.DEV.337
FriendXP, v1.10
Gatherer, v<%version%>
HealBot, v5.0.5.3
Informant, v5.1.DEV.5347
LibDataBroker, v
LibExtraTip, v5.12.DEV.342
Omen, v3.1.7
PetBattleQualityGlow, v1.0.3
PetJournalEnhanced, v2.3.3
QuestCompletist, v99.9
Rarity, v1.0
RarityOptions, v
Recount, v
SellOMatic, vl04-2
SlideBar, v5.1.DEV.312
Stubby, v5.1.DEV.275
TipHelper, v5.12.DEV.343
Titan, v5.1.7.50001
TitanBag, v5.1.7.50001
TitanClock, v5.1.7.50001
TitanGold, v5.1.5.50001
TitanLocation, v5.1.7.50001
TitanLootType, v5.1.7.50001
TitanMail, v4.07.50001
TitanPerformance, v5.1.7.50001
TitanRepair, v5.1.7.50001
TitanVolume, v5.1.7.50001
TitanXP, v5.1.7.50001
ZygorGuidesViewer, v4.0
BlizRuntimeLib_enUS v5.0.5.50001 <us>
(ck=5ab)


The new one seems to make some things worse too. Got this from same fight that got my spam in the general window.

[prowell]

Followed by first time I tried to go to a vendor.

Date: 2012-10-07 01:28:45
ID: 4
Error occured in: Global
Count: 1
Message: ..\AddOns\ZygorGuidesViewer\Loot.lua line 203:
attempt to index field 'CurrentStep' (a nil value)
Debug:
ZygorGuidesViewer\Loot.lua:203:
ZygorGuidesViewer\Loot.lua:201
ZygorGuidesViewer\Loot.lua:290:
ZygorGuidesViewer\Loot.lua:272
Locals:
(*temporary) = nil


This new version breaks even worse when no guide is selected.

[cabby]

Please run your Updater, click Repair, click Refresh, and then install a fresh copy of the guides.

[prowell]

This morning there was another update. This update, which wasn't available when you first said update, seems to have corrected the issue.
Will be playing for an hour, and will report here if I see any issues.

[prowell]

The latest update fixes the two lua errors, but the logic error that spams chat is still there. A message is sent after every combat.

Might I suggest wrapping the code that gives that message in:

-- place above function with message

local failed_initial_selection = false

if not failed_initial_selection
begin
-- check initial selection and what should be selected, printing if none selected

-- if it fails, where the print message is
if failed
begin
done_initial_selection=true
end

That at least stops the spam, and probably cuts down what you are doing all the time when it is totally useless...

[prowell]

Might i suggest a construct like the following?

-- above function, file scope
local failed_initial_selection = false


-- where you are trying to reselect the guide
if not failed_initial_selection
begin
-- Try to find correct guide

-- Check Status and print message if failed
if failed
begin
-- print message here
failed_initial_selection=true
end
end


This should stop spam and cut down what you are doing useless for each state change.
Simple logic: if it failed last time, it will fail this time so why try again until the guide is changed (which requires a UI reload at the minimum).

[cabby]

That might not be implemented for a while as it's a minor bug with a very easy work-a-round, just load a guide.